Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753637AbcJLGAj (ORCPT ); Wed, 12 Oct 2016 02:00:39 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:33161 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbcJLF7p (ORCPT ); Wed, 12 Oct 2016 01:59:45 -0400 MIME-Version: 1.0 In-Reply-To: <1476228174-1818-1-git-send-email-chasemetzger15@gmail.com> References: <1476228174-1818-1-git-send-email-chasemetzger15@gmail.com> From: Vaibhav Agarwal Date: Wed, 12 Oct 2016 11:29:13 +0530 Message-ID: Subject: Re: [PATCH] drivers: staging: greybus: audio_manager_sysfs.c: Fixed CHECK for brace issue To: Chase Metzger Cc: Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1088 Lines: 30 On Wed, Oct 12, 2016 at 4:52 AM, Chase Metzger wrote: > Added braces to else and else if statements where checkpatch complained. > > Signed-off-by: Chase Metzger > --- > drivers/staging/greybus/audio_manager_sysfs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c > index d8bf859..376e17c 100644 > --- a/drivers/staging/greybus/audio_manager_sysfs.c > +++ b/drivers/staging/greybus/audio_manager_sysfs.c > @@ -71,10 +71,11 @@ static ssize_t manager_sysfs_dump_store( > num = gb_audio_manager_dump_module(id); > if (num) > return num; > - } else if (!strncmp("all", buf, 3)) > + } else if (!strncmp("all", buf, 3)) { > gb_audio_manager_dump_all(); > - else > + } else { > return -EINVAL; > + } > > return count; > } > -- > 2.1.4 > Reviewed-by: Vaibhav Agarwal