Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753598AbcJLGF1 (ORCPT ); Wed, 12 Oct 2016 02:05:27 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:35446 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753371AbcJLGFS (ORCPT ); Wed, 12 Oct 2016 02:05:18 -0400 MIME-Version: 1.0 In-Reply-To: <1476229807-11349-1-git-send-email-chasemetzger15@gmail.com> References: <1476229807-11349-1-git-send-email-chasemetzger15@gmail.com> From: Vaibhav Agarwal Date: Wed, 12 Oct 2016 11:34:56 +0530 Message-ID: Subject: Re: [PATCH] drivers: staging: greybus: audio_topology.c: Fixed CHECKS for brace issues To: Chase Metzger Cc: Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1934 Lines: 44 On Wed, Oct 12, 2016 at 5:19 AM, Chase Metzger wrote: > Added braces for else and else if statements where checkpatch complained. > > Signed-off-by: Chase Metzger > --- > drivers/staging/greybus/audio_topology.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/audio_topology.c b/drivers/staging/greybus/audio_topology.c > index b625169..3a2678e 100644 > --- a/drivers/staging/greybus/audio_topology.c > +++ b/drivers/staging/greybus/audio_topology.c > @@ -1044,8 +1044,10 @@ static int gbaudio_tplg_create_widget(struct gbaudio_module_info *module, > control->texts = (const char * const *) > gb_generate_enum_strings(module, gbenum); > control->items = gbenum->items; > - } else > + } else { > csize = sizeof(struct gb_audio_control); > + } > + > *w_size += csize; > curr = (void *)curr + csize; > list_add(&control->list, &module->widget_ctl_list); > @@ -1190,8 +1192,9 @@ static int gbaudio_tplg_process_kcontrols(struct gbaudio_module_info *module, > control->texts = (const char * const *) > gb_generate_enum_strings(module, gbenum); > control->items = gbenum->items; > - } else > + } else { > csize = sizeof(struct gb_audio_control); > + } > > list_add(&control->list, &module->ctl_list); > dev_dbg(module->dev, "%d:%s created of type %d\n", curr->id, > -- > 2.1.4 > You have already submitted a similar patch available on staging-testing branch: commit b7e0c9eca426 ("drivers: staging: greybus: Fixed CHECKS for brace issues") -- thanks, ./va