Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753757AbcJLGWp (ORCPT ); Wed, 12 Oct 2016 02:22:45 -0400 Received: from smtp11.smtpout.orange.fr ([80.12.242.133]:52350 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752607AbcJLGWg (ORCPT ); Wed, 12 Oct 2016 02:22:36 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 12 Oct 2016 08:22:33 +0200 X-ME-IP: 90.38.43.100 From: Robert Jarzmik To: Viresh Kumar Cc: Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 6/6] cpufreq: pxa: convert to clock API References: <1476130149-31834-1-git-send-email-robert.jarzmik@free.fr> <1476130149-31834-7-git-send-email-robert.jarzmik@free.fr> <20161012023601.GC19385@vireshk-i7> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 12 Oct 2016 08:22:30 +0200 In-Reply-To: <20161012023601.GC19385@vireshk-i7> (Viresh Kumar's message of "Wed, 12 Oct 2016 08:06:01 +0530") Message-ID: <87mvia6q8p.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 24 Viresh Kumar writes: > On 10-10-16, 22:09, Robert Jarzmik wrote: >> As the clock settings have been introduced into the clock pxa drivers, >> which are now available to change the CPU clock by themselves, remove >> the clock handling from this driver, and rely on pxa clock drivers. >> >> Signed-off-by: Robert Jarzmik >> --- >> drivers/cpufreq/pxa2xx-cpufreq.c | 191 ++++++++------------------------------- >> 1 file changed, 39 insertions(+), 152 deletions(-) > > As you mentioned in the previous patch, why can't you use cpufreq-dt > driver now and delete this one ? PXA architecture have both legacy platform_data based configurations and new devicetree based ones. I don't think cpufreq-dt can handle the legacy platform_data ones, can it ? Cheers. -- Robert