Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753250AbcJLGjg (ORCPT ); Wed, 12 Oct 2016 02:39:36 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34796 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbcJLGjf (ORCPT ); Wed, 12 Oct 2016 02:39:35 -0400 Date: Wed, 12 Oct 2016 12:02:47 +0530 From: Viresh Kumar To: Robert Jarzmik Cc: Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 6/6] cpufreq: pxa: convert to clock API Message-ID: <20161012063247.GH19385@vireshk-i7> References: <1476130149-31834-1-git-send-email-robert.jarzmik@free.fr> <1476130149-31834-7-git-send-email-robert.jarzmik@free.fr> <20161012023601.GC19385@vireshk-i7> <87mvia6q8p.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mvia6q8p.fsf@belgarion.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 895 Lines: 24 On 12-10-16, 08:22, Robert Jarzmik wrote: > Viresh Kumar writes: > > > On 10-10-16, 22:09, Robert Jarzmik wrote: > >> As the clock settings have been introduced into the clock pxa drivers, > >> which are now available to change the CPU clock by themselves, remove > >> the clock handling from this driver, and rely on pxa clock drivers. > >> > >> Signed-off-by: Robert Jarzmik > >> --- > >> drivers/cpufreq/pxa2xx-cpufreq.c | 191 ++++++++------------------------------- > >> 1 file changed, 39 insertions(+), 152 deletions(-) > > > > As you mentioned in the previous patch, why can't you use cpufreq-dt > > driver now and delete this one ? > > PXA architecture have both legacy platform_data based configurations and new > devicetree based ones. I don't see any platform data specific code in this driver. What am I missing ? -- viresh