Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754688AbcJLIP7 (ORCPT ); Wed, 12 Oct 2016 04:15:59 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:36523 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbcJLIPs (ORCPT ); Wed, 12 Oct 2016 04:15:48 -0400 Subject: Re: [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control To: Rob Herring References: <20161006051355.15947-1-mugunthanvnm@ti.com> <20161006051355.15947-2-mugunthanvnm@ti.com> <20161010131841.GA8391@rob-hp-laptop> CC: , , , , , Mark Rutland , Tony Lindgren , Russell King , Florian Fainelli , David Miller , Sekhar Nori From: Mugunthan V N Message-ID: Date: Wed, 12 Oct 2016 13:43:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161010131841.GA8391@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1454 Lines: 39 On Monday 10 October 2016 06:48 PM, Rob Herring wrote: > On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote: >> Add documention of ti,impedance-control which can be used to > > Needs updating. Oops, will update this in next version. > >> correct MAC impedance mismatch using phy extended registers. >> >> Signed-off-by: Mugunthan V N >> --- >> Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt b/Documentation/devicetree/bindings/net/ti,dp83867.txt >> index 5d21141..85bf945 100644 >> --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt >> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt >> @@ -9,6 +9,18 @@ Required properties: >> - ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h >> for applicable values >> >> +Optional property: >> + - ti,min-output-impedance - MAC Interface Impedance control to set >> + the programmable output impedance to >> + minimum value (35 ohms). >> + - ti,max-output-impedance - MAC Interface Impedance control to set >> + the programmable output impedance to >> + maximum value (70 ohms). > > Define what are valid range of values for these. The values are already mentioned in documentation as 35/70 ohms. Are you mentioning about the register values? Regards Mugunthan V N