Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932281AbcJLI3Q (ORCPT ); Wed, 12 Oct 2016 04:29:16 -0400 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:53300 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754306AbcJLI3K (ORCPT ); Wed, 12 Oct 2016 04:29:10 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 12 Oct 2016 10:29:07 +0200 X-ME-IP: 90.38.43.100 From: Robert Jarzmik To: Viresh Kumar Cc: Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 6/6] cpufreq: pxa: convert to clock API References: <1476130149-31834-1-git-send-email-robert.jarzmik@free.fr> <1476130149-31834-7-git-send-email-robert.jarzmik@free.fr> <20161012023601.GC19385@vireshk-i7> <87mvia6q8p.fsf@belgarion.home> <20161012063247.GH19385@vireshk-i7> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 12 Oct 2016 10:29:05 +0200 In-Reply-To: <20161012063247.GH19385@vireshk-i7> (Viresh Kumar's message of "Wed, 12 Oct 2016 12:02:47 +0530") Message-ID: <87insy6kdq.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1208 Lines: 34 Viresh Kumar writes: > On 12-10-16, 08:22, Robert Jarzmik wrote: >> Viresh Kumar writes: >> >> > On 10-10-16, 22:09, Robert Jarzmik wrote: >> >> As the clock settings have been introduced into the clock pxa drivers, >> >> which are now available to change the CPU clock by themselves, remove >> >> the clock handling from this driver, and rely on pxa clock drivers. >> >> >> >> Signed-off-by: Robert Jarzmik >> >> --- >> >> drivers/cpufreq/pxa2xx-cpufreq.c | 191 ++++++++------------------------------- >> >> 1 file changed, 39 insertions(+), 152 deletions(-) >> > >> > As you mentioned in the previous patch, why can't you use cpufreq-dt >> > driver now and delete this one ? >> >> PXA architecture have both legacy platform_data based configurations and new >> devicetree based ones. > > I don't see any platform data specific code in this driver. What am I > missing ? In a legacy platform, ie. without devicetree, we have CONFIG_OF=n. How would cpufreq-dt be usable in this case ? You can see such a platform in arch/arm/configs/mainstone_defconfig and arch/arm/mach-pxa/mainstone.c as an example. Cheers. -- Robert