Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755172AbcJLMm1 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 12 Oct 2016 08:42:27 -0400
Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:52436 "EHLO
        lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753933AbcJLMl0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 12 Oct 2016 08:41:26 -0400
Message-ID: <1476275787.9670.12.camel@tiscali.nl>
Subject: Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning
From: Paul Bolle <pebolle@tiscali.nl>
To: Luca Coelho <luca@coelho.fi>, Chris Rorvick <chris@rorvick.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Johannes Berg <johannes.berg@intel.com>,
        Kalle Valo <kvalo@codeaurora.org>, Oren Givon <oren.givon@intel.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Wed, 12 Oct 2016 14:36:27 +0200
In-Reply-To: <1476275099.7776.28.camel@coelho.fi>
References: <20161010071943.4717-1-chris@rorvick.com>
         <1476108164.5210.11.camel@coelho.fi> <1476180668.17022.21.camel@tiscali.nl>
         <CAEUsAPbEf=hr1ki267qKpenWW_UBO93KY8q6-EdqWpk15Yhcnw@mail.gmail.com>
         <1476275099.7776.28.camel@coelho.fi>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1374
Lines: 33

On Wed, 2016-10-12 at 15:24 +0300, Luca Coelho wrote:
> Okay... Actually this is a structure in the BIOS and the actual method
> we call is SPLC.  The SPLC method may return one item from this table,
> or something entirely different, possible one of the three values
> depending on a configuration option or so.
> 
> Can you to find and send me the actual SPLC method that we call, from
> your BIOS?

It seems Chris and I basically have identical setups, so I'll answer.

There are 20 SPLC methods in the BIOS. The first reads
    Method (SPLC, 0, Serialized)
    {
        DerefOf (SPLX [One]) [Zero] = DOM1 /* \DOM1 */
        DerefOf (SPLX [One]) [One] = LIM1 /* \LIM1 */
        DerefOf (SPLX [One]) [0x02] = TIM1 /* \TIM1 */
        DerefOf (SPLX [0x02]) [Zero] = DOM2 /* \DOM2 */
        DerefOf (SPLX [0x02]) [One] = LIM2 /* \LIM2 */
        DerefOf (SPLX [0x02]) [0x02] = TIM2 /* \TIM2 */
        DerefOf (SPLX [0x03]) [Zero] = DOM3 /* \DOM3 */
        DerefOf (SPLX [0x03]) [One] = LIM3 /* \LIM3 */
        DerefOf (SPLX [0x03]) [0x02] = TIM3 /* \TIM3 */
        Return (SPLX) /* \_SB_.PCI0.RP01.PXSX.SPLX */
    }

The only difference is in the last comment. Ie, RP01 is increased until
it reaches RP20. (The machine has 20 PCI devices according to lspci. I
have no clue how to match that RPxx number to the 20 devices showing up
in lspci, sorry.)


Paul Bolle