Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932856AbcJLNB3 (ORCPT ); Wed, 12 Oct 2016 09:01:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:48122 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932473AbcJLMo0 (ORCPT ); Wed, 12 Oct 2016 08:44:26 -0400 From: lizf@kernel.org To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Colin Ian King , Li Bin , Russell King , Will Deacon , Steven Rostedt , Zefan Li Subject: [PATCH 3.4 109/125] ftrace/scripts: Fix incorrect use of sprintf in recordmcount Date: Wed, 12 Oct 2016 20:33:45 +0800 Message-Id: <1476275641-4697-109-git-send-email-lizf@kernel.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1476275600-4626-1-git-send-email-lizf@kernel.org> References: <1476275600-4626-1-git-send-email-lizf@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 43 From: Colin Ian King 3.4.113-rc1 review patch. If anyone has any objections, please let me know. ------------------ commit 713a3e4de707fab49d5aa4bceb77db1058572a7b upstream. Fix build warning: scripts/recordmcount.c:589:4: warning: format not a string literal and no format arguments [-Wformat-security] sprintf("%s: failed\n", file); Fixes: a50bd43935586 ("ftrace/scripts: Have recordmcount copy the object file") Link: http://lkml.kernel.org/r/1451516801-16951-1-git-send-email-colin.king@canonical.com Cc: Li Bin Cc: Russell King Cc: Will Deacon Signed-off-by: Colin Ian King Signed-off-by: Steven Rostedt Signed-off-by: Zefan Li --- scripts/recordmcount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c index 0970379..0d5ae4a 100644 --- a/scripts/recordmcount.c +++ b/scripts/recordmcount.c @@ -546,7 +546,7 @@ main(int argc, char *argv[]) do_file(file); break; case SJ_FAIL: /* error in do_file or below */ - sprintf("%s: failed\n", file); + fprintf(stderr, "%s: failed\n", file); ++n_error; break; case SJ_SUCCEED: /* premature success */ -- 1.9.1