Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755549AbcJLNJN (ORCPT ); Wed, 12 Oct 2016 09:09:13 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:53065 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755369AbcJLNJE (ORCPT ); Wed, 12 Oct 2016 09:09:04 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Wed, 12 Oct 2016 15:08:21 +0200 From: Stefan Richter To: lizf@kernel.org Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Zefan Li Subject: Re: [PATCH 3.4 027/125] firewire: ohci: fix JMicron JMB38x IT context discovery Message-ID: <20161012150821.7f8bda8c@kant> In-Reply-To: <1476275641-4697-27-git-send-email-lizf@kernel.org> References: <1476275600-4626-1-git-send-email-lizf@kernel.org> <1476275641-4697-27-git-send-email-lizf@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 31 On Oct 12 lizf@kernel.org wrote: [...] > Signed-off-by: Stefan Richter > [lizf: Backported to 3.4: use dev_notice() instead of ohci_notice()] > Signed-off-by: Zefan Li > --- > drivers/firewire/ohci.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c > index c1de4c3..4eedb07 100644 > --- a/drivers/firewire/ohci.c > +++ b/drivers/firewire/ohci.c > @@ -3620,6 +3620,11 @@ static int __devinit pci_probe(struct pci_dev *dev, > > reg_write(ohci, OHCI1394_IsoXmitIntMaskSet, ~0); > ohci->it_context_support = reg_read(ohci, OHCI1394_IsoXmitIntMaskSet); > + /* JMicron JMB38x often shows 0 at first read, just ignore it */ > + if (!ohci->it_context_support) { > + dev_notice(&dev->dev, "overriding IsoXmitIntMask\n"); > + ohci->it_context_support = 0xf; > + } > reg_write(ohci, OHCI1394_IsoXmitIntMaskClear, ~0); > ohci->it_context_mask = ohci->it_context_support; > ohci->n_it = hweight32(ohci->it_context_mask); Backport looks good to me. Thanks. -- Stefan Richter -======----- =-=- -==-- http://arcgraph.de/sr/