MIME-Version: 1.0
In-Reply-To: <20161012053842.GF19385@vireshk-i7>
References: <1475882487-2155-1-git-send-email-mmayer@broadcom.com>
 <1475882487-2155-3-git-send-email-mmayer@broadcom.com> <20161012053842.GF19385@vireshk-i7>
From: Markus Mayer <markus.mayer@broadcom.com>
Date: Wed, 12 Oct 2016 09:08:24 -0700
Message-ID: <CAGt4E5uV4y3mKarxNL1hjYAZSu02H6eHdRTCRgc-U03hb5ApLw@mail.gmail.com>
Subject: Re: [PATCH v3 2/3] cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver
 for Broadcom STB SoCs
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
        Device Tree List <devicetree@vger.kernel.org>,
        Power Management List <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 650
Lines: 25

On 11 October 2016 at 22:38, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 07-10-16, 16:21, Markus Mayer wrote:
>> +static int brcm_avs_cpufreq_exit(struct cpufreq_policy *policy)
>> +{
>> +     struct private_data *priv = policy->driver_data;
>> +
>> +     iounmap(priv->base);
>> +     iounmap(priv->avs_intr_base);
>> +
>> +     return 0;
>> +}
>
> Shouldn't the above be done in the below routine instead ?

Good point. I'll move it.

>> +static int brcm_avs_cpufreq_remove(struct platform_device *pdev)
>> +{
>> +     platform_set_drvdata(pdev, NULL);
>> +
>> +     return cpufreq_unregister_driver(&brcm_avs_driver);
>> +}
>
> --
> viresh