Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755943AbcJLQzP (ORCPT ); Wed, 12 Oct 2016 12:55:15 -0400 Received: from mail-vk0-f43.google.com ([209.85.213.43]:35241 "EHLO mail-vk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755917AbcJLQy4 (ORCPT ); Wed, 12 Oct 2016 12:54:56 -0400 MIME-Version: 1.0 In-Reply-To: <1476290430-19542-1-git-send-email-benjamin.tissoires@redhat.com> References: <1476290430-19542-1-git-send-email-benjamin.tissoires@redhat.com> From: Benjamin Tissoires Date: Wed, 12 Oct 2016 18:47:04 +0200 Message-ID: Subject: Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get() To: Linus Walleij , Alexandre Courbot , Mika Westerberg Cc: David Arcari , linux-gpio@vger.kernel.org, "linux-kernel@vger.kernel.org" , Benjamin Tissoires Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 25 On Wed, Oct 12, 2016 at 6:40 PM, Benjamin Tissoires wrote: > From: David Arcari > > acpi_dev_gpio_irq_get() currently ignores the error returned > by acpi_get_gpiod_by_index() and overwrites it with -ENOENT. > > Problem is this error can be -EPROBE_DEFER, which just blows > up some drivers when the module ordering is not correct. > > Cc: stable@vger.kernel.org > Signed-off-by: David Arcari > Signed-off-by: Benjamin Tissoires > --- > > Hi David, > > I am planning on sending this to the list, any last minute comments? Of course, I forgot to remove our internal sync comment. David's answer was "No. This looks good to me.", so I just went ahead and send the patch. Cheers, Benjamin