Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933629AbcJMBQa (ORCPT ); Wed, 12 Oct 2016 21:16:30 -0400 Received: from mx4.wp.pl ([212.77.101.12]:37619 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933116AbcJMBQV (ORCPT ); Wed, 12 Oct 2016 21:16:21 -0400 X-Greylist: delayed 1651 seconds by postgrey-1.27 at vger.kernel.org; Wed, 12 Oct 2016 21:15:57 EDT Date: Thu, 13 Oct 2016 01:48:20 +0100 From: Jakub Kicinski To: Julia Cartwright Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Sean Nyekjaer , Josh Cartwright , linux-rt-users@vger.kernel.org, stable@vger.kernel.org, linux-serial@vger.kernel.org, Sebastian Andrzej Siewior Subject: Re: [PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT Message-ID: <20161013014820.241424bf@laptop> In-Reply-To: <20161003151432.17828-1-julia@ni.com> References: <20161003151432.17828-1-julia@ni.com> X-Mailer: Claws Mail 3.14.0-49-g1cc35f (GTK+ 2.24.30; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 8aed6c266d40fa603d662563a2231028 X-WP-AV: skaner antywirusowy poczty Nowej Poczty X-WP-SPAM: NO 000000A [gROk] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 427 Lines: 15 On Mon, 3 Oct 2016 10:14:32 -0500, Julia Cartwright wrote: > The use of IRQF_ONESHOT when registering an interrupt handler with > request_irq() is non-sensical. > ... Disabling the irq when kthread is pending as mentioned here: http://www.spinics.net/lists/linux-rt-users/msg14673.html could be beneficial but this is definitely a step in the right direction! Acked-by: Jakub Kicinski Thanks a lot Julia!