Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933987AbcJMCen (ORCPT ); Wed, 12 Oct 2016 22:34:43 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:12656 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933707AbcJMCee (ORCPT ); Wed, 12 Oct 2016 22:34:34 -0400 From: "Longpeng(Mike)" To: , , , , , CC: , , , , Subject: [PATCH v2] kvm: x86: remove the misleading comment in vmx_handle_external_intr Date: Thu, 13 Oct 2016 10:34:11 +0800 Message-ID: <1476326051-83916-1-git-send-email-longpeng2@huawei.com> X-Mailer: git-send-email 1.8.4.msysgit.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.246.209] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 33 Since Paolo has removed irq-enable-operation in vmx_handle_external_intr (KVM: x86: use guest_exit_irqoff), the original comment about the IF bit in rflags is incorrect and stale now, so remove it. Signed-off-by: Longpeng(Mike) --- Hi Radim, Changes since v1: - remove this stale comment instead. --- arch/x86/kvm/vmx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index cf1b16d..e06c8b1 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -8646,11 +8646,6 @@ static void vmx_handle_external_intr(struct kvm_vcpu *vcpu) u32 exit_intr_info = vmcs_read32(VM_EXIT_INTR_INFO); register void *__sp asm(_ASM_SP); - /* - * If external interrupt exists, IF bit is set in rflags/eflags on the - * interrupt stack frame, and interrupt will be enabled on a return - * from interrupt handler. - */ if ((exit_intr_info & (INTR_INFO_VALID_MASK | INTR_INFO_INTR_TYPE_MASK)) == (INTR_INFO_VALID_MASK | INTR_TYPE_EXT_INTR)) { unsigned int vector; -- 1.8.3.1