Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755558AbcJMGfW (ORCPT ); Thu, 13 Oct 2016 02:35:22 -0400 Received: from mailapp02.imgtec.com ([217.156.133.132]:41286 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755307AbcJMGfR (ORCPT ); Thu, 13 Oct 2016 02:35:17 -0400 Subject: Re: [PATCH v3 05/11] x86/tracing: fix compat syscall handling To: Thomas Gleixner References: <1476182576-15247-1-git-send-email-marcin.nowakowski@imgtec.com> <1476182576-15247-6-git-send-email-marcin.nowakowski@imgtec.com> CC: , , , , Ingo Molnar , "H. Peter Anvin" , From: Marcin Nowakowski Message-ID: <413d180f-2620-7471-8fa9-f576e3a457b2@imgtec.com> Date: Thu, 13 Oct 2016 08:32:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.2.5] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 18 On 12.10.2016 15:53, Thomas Gleixner wrote: > On Tue, 11 Oct 2016, Marcin Nowakowski wrote: >> -/* >> - * Because ia32 syscalls do not map to x86_64 syscall numbers >> - * this screws up the trace output when tracing a ia32 task. >> - * Instead of reporting bogus syscalls, just do not trace them. >> - * >> - * If the user really wants these, then they should use the >> - * raw syscall tracepoints with filtering. > > Why aren't you moving this information to the new place? It's valuable. Well - much of this information is no longer true as with these fixes tracing can work properly, but I can keep a note clarifying that the numbers are mapped differently and why arch_syscall_addr() needs the sort of handling it does. Marcin