Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751246AbcJMHLp (ORCPT ); Thu, 13 Oct 2016 03:11:45 -0400 Received: from mga03.intel.com ([134.134.136.65]:49839 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019AbcJMHLg (ORCPT ); Thu, 13 Oct 2016 03:11:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,339,1473145200"; d="scan'208";a="1069806878" Date: Thu, 13 Oct 2016 10:10:31 +0300 From: Mika Westerberg To: Benjamin Tissoires Cc: Linus Walleij , Alexandre Courbot , David Arcari , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio / ACPI: fix returned error from acpi_dev_gpio_irq_get() Message-ID: <20161013071031.GD2774@lahna.fi.intel.com> References: <1476290430-19542-1-git-send-email-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476290430-19542-1-git-send-email-benjamin.tissoires@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 576 Lines: 14 On Wed, Oct 12, 2016 at 06:40:30PM +0200, Benjamin Tissoires wrote: > From: David Arcari > > acpi_dev_gpio_irq_get() currently ignores the error returned > by acpi_get_gpiod_by_index() and overwrites it with -ENOENT. > > Problem is this error can be -EPROBE_DEFER, which just blows > up some drivers when the module ordering is not correct. > > Cc: stable@vger.kernel.org > Signed-off-by: David Arcari > Signed-off-by: Benjamin Tissoires Acked-by: Mika Westerberg