Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbcJMHVU (ORCPT ); Thu, 13 Oct 2016 03:21:20 -0400 Received: from mailapp02.imgtec.com ([217.156.133.132]:40177 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751335AbcJMHVN (ORCPT ); Thu, 13 Oct 2016 03:21:13 -0400 Subject: Re: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board To: Rob Herring References: <1475757094-31089-1-git-send-email-rahul.bedarkar@imgtec.com> <1475757094-31089-2-git-send-email-rahul.bedarkar@imgtec.com> <20161010142152.GA7920@rob-hp-laptop> CC: Ralf Baechle , Mark Rutland , James Hartley , , , From: Rahul Bedarkar Message-ID: <57FF3172.4010709@imgtec.com> Date: Thu, 13 Oct 2016 12:32:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20161010142152.GA7920@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.91.23] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 23 Hi, On Monday 10 October 2016 07:51 PM, Rob Herring wrote: >> + >> + memory { > > Is 0 the actual base, or that gets filled in by bootloader? If the > formet, add unit address. > Bootloader (uboot) can override or fixup memory node. But with version of bootloader I tested with, base address is hardcoded to 0 and only size may get changed. But since booloader can override or fixup memory node, I assume we don't add unit address in this case. >> + device_type = "memory"; >> + reg = <0x00000000 0x08000000>; I now realized that size is incorrectly specified in memory node. It should be 256MB and not 128MB. I will fix this in v2. Thanks, Rahul