Subject: Re: [PATCH 3.4 088/125] ser_gigaset: fix deallocation of platform
 device structure
To: Paul Bolle <pebolle@tiscali.nl>, <lizf@kernel.org>,
        <stable@vger.kernel.org>
References: <1476275600-4626-1-git-send-email-lizf@kernel.org>
 <1476275641-4697-88-git-send-email-lizf@kernel.org>
 <1476276740.9670.19.camel@tiscali.nl> <57FEF708.2060405@huawei.com>
 <1476346316.3526.29.camel@tiscali.nl>
CC: <linux-kernel@vger.kernel.org>, Tilman Schmidt <tilman@imap.cc>,
        "David S. Miller" <davem@davemloft.net>
From: Zefan Li <lizefan@huawei.com>
Message-ID: <57FF4AD1.2040908@huawei.com>
Date: Thu, 13 Oct 2016 16:50:25 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1476346316.3526.29.camel@tiscali.nl>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1129
Lines: 28

On 2016/10/13 16:11, Paul Bolle wrote:
> On Thu, 2016-10-13 at 10:52 +0800, Zefan Li wrote:
>> On 2016/10/12 20:52, Paul Bolle wrote:
>>> There has been a follow up for this fix. I'll have to dive into my
>>> archive to see why that was needed.
>>>
>>> It was complicated, because there has been a short period in which this
>>> fix was correct. Something like that, I'm speaking from memory.
>>> (Perhaps Tilman's memory is less imperfect.)
>>>
>>> I'll try get back to this shortly (in a day or so).
>>>
>>
>> Thanks for looking into this.
> 
> So what I think you also need _on top of_ this patch:
> - commit 8aeb3c3d655e ("ser_gigaset: remove unnecessary kfree() calls
> from release method"), for context changes; and
> - commit 8d2c3ab44456 ("ser_gigaset: use container_of() instead of
> detour"), the proper fix.
> 
> I could not get v3.4 to build _at all_ on my current Fedora 24 machine.
> (v3.4 was probably released when Fedora 16 was still shiny and new.)
> Lack of coffee? So I've only visually inspected these three commits on
> top of v3.4.112. Is that acceptable to you?
> 

Yeah, I'll take it from here. Thanks!