Date: Thu, 13 Oct 2016 14:36:13 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: "Longpeng(Mike)" <longpeng2@huawei.com>
Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, x86@kernel.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, wu.wubin@huawei.com,
        zhaoshenglong@huawei.com
Subject: Re: [PATCH v2] kvm: x86: remove the misleading comment in
 vmx_handle_external_intr
Message-ID: <20161013123612.GE16406@potion>
References: <1476326051-83916-1-git-send-email-longpeng2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1476326051-83916-1-git-send-email-longpeng2@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1188
Lines: 38

2016-10-13 10:34+0800, Longpeng(Mike):
> Since Paolo has removed irq-enable-operation in vmx_handle_external_intr
> (KVM: x86: use guest_exit_irqoff), the original comment about the IF bit
> in rflags is incorrect and stale now, so remove it.
> 
> Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
> ---
> Hi Radim,
> 
> Changes since v1:
>  - remove this stale comment instead.
> ---

Applied to kvm/queue, thanks.

>  arch/x86/kvm/vmx.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index cf1b16d..e06c8b1 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -8646,11 +8646,6 @@ static void vmx_handle_external_intr(struct kvm_vcpu *vcpu)
>  	u32 exit_intr_info = vmcs_read32(VM_EXIT_INTR_INFO);
>  	register void *__sp asm(_ASM_SP);
>  
> -	/*
> -	 * If external interrupt exists, IF bit is set in rflags/eflags on the
> -	 * interrupt stack frame, and interrupt will be enabled on a return
> -	 * from interrupt handler.
> -	 */
>  	if ((exit_intr_info & (INTR_INFO_VALID_MASK | INTR_INFO_INTR_TYPE_MASK))
>  			== (INTR_INFO_VALID_MASK | INTR_TYPE_EXT_INTR)) {
>  		unsigned int vector;
> -- 
> 1.8.3.1
> 
>