Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932182AbcJMMta (ORCPT ); Thu, 13 Oct 2016 08:49:30 -0400 Received: from mail.kernel.org ([198.145.29.136]:55464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753977AbcJMMtV (ORCPT ); Thu, 13 Oct 2016 08:49:21 -0400 Date: Thu, 13 Oct 2016 20:49:04 +0800 From: Shawn Guo To: Zhi Li , Mark Rutland Cc: Frank Li , "linux-arm-kernel@lists.infradead.org" , kernel list , peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jerry shen , Zhengyu Shen Subject: Re: [PATCH 1/1 v8] ARM: imx: Added perf functionality to mmdc driver Message-ID: <20161013124904.GA25183@tiger> References: <1474307849-7341-1-git-send-email-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1848 Lines: 45 On Mon, Oct 10, 2016 at 03:17:36PM -0500, Zhi Li wrote: > On Mon, Sep 26, 2016 at 11:40 AM, Zhi Li wrote: > > On Mon, Sep 19, 2016 at 12:57 PM, Frank Li wrote: > >> From: Zhengyu Shen > >> > >> MMDC is a multi-mode DDR controller that supports DDR3/DDR3L x16/x32/x64 > >> and LPDDR2 two channel x16/x32 memory types. MMDC is configurable, high > >> performance, and optimized. MMDC is present on i.MX6 Quad and i.MX6 > >> QuadPlus devices, but this driver only supports i.MX6 Quad at the moment. > >> MMDC provides registers for performance counters which read via this > >> driver to help debug memory throughput and similar issues. > >> > >> $ perf stat -a -e mmdc/busy-cycles/,mmdc/read-accesses/,mmdc/read-bytes/,mmdc/total-cycles/,mmdc/write-accesses/,mmdc/write-bytes/ dd if=/dev/zero of=/dev/null bs=1M count=5000 > >> Performance counter stats for 'dd if=/dev/zero of=/dev/null bs=1M count=5000': > >> > >> 898021787 mmdc/busy-cycles/ > >> 14819600 mmdc/read-accesses/ > >> 471.30 MB mmdc/read-bytes/ > >> 2815419216 mmdc/total-cycles/ > >> 13367354 mmdc/write-accesses/ > >> 427.76 MB mmdc/write-bytes/ > >> > >> 5.334757334 seconds time elapsed > >> > >> Signed-off-by: Zhengyu Shen > >> Signed-off-by: Frank Li > >> --- > > > > Mark: > > Any additional comments for this version? > > > > Shawn: > No any new comment for more than 2 weeks. > Did you plan accept this patch? We normally do not apply patches in the middle of a merge window. I plan to apply it when 4.9-rc1 comes out. But I still would like to get a Reviewed-by tag from Mark before doing that. @Mark, Are you happy with this version? Shawn