Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754144AbcJMNpk (ORCPT ); Thu, 13 Oct 2016 09:45:40 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60746 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbcJMNpb (ORCPT ); Thu, 13 Oct 2016 09:45:31 -0400 Date: Thu, 13 Oct 2016 09:43:23 -0400 (EDT) Message-Id: <20161013.094323.1769619439752576215.davem@davemloft.net> To: khoroshilov@ispras.ru Cc: skhare@vmware.com, pv-drivers@vmware.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc() From: David Miller In-Reply-To: <1475895223-3225-1-git-send-email-khoroshilov@ispras.ru> References: <1475895223-3225-1-git-send-email-khoroshilov@ispras.ru> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 13 Oct 2016 06:43:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 559 Lines: 16 From: Alexey Khoroshilov Date: Fri, 7 Oct 2016 22:53:43 -0400 > vmxnet3_set_mc() still assumes zero is invalid pa: > it assumes dma_mapping_error(...,0) returns true if vmxnet3_copy_mc() fails; > it calls dma_unmap_single() iff new_table_pa is not zero. > > The patch adds an explicit variable to track status of new_table_pa. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Please use "bool" and "true"/"false" for boolean variables. Thanks.