Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755396AbcJMNzm (ORCPT ); Thu, 13 Oct 2016 09:55:42 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60938 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755070AbcJMNze (ORCPT ); Thu, 13 Oct 2016 09:55:34 -0400 Date: Thu, 13 Oct 2016 09:55:32 -0400 (EDT) Message-Id: <20161013.095532.1238800778112994579.davem@davemloft.net> To: arnd@arndb.de Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com, everest-linux-l2@qlogic.com, Ram.Amrani@caviumnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qed: fix old-style function definition From: David Miller In-Reply-To: <20161010115937.730249-1-arnd@arndb.de> References: <20161010115937.730249-1-arnd@arndb.de> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 13 Oct 2016 06:55:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9DDtnbo018574 Content-Length: 597 Lines: 16 From: Arnd Bergmann Date: Mon, 10 Oct 2016 13:59:16 +0200 > The definition of qed_get_rdma_ops() is not a prototype unless > we add 'void' here, as indicated by this W=1 warning: > > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ?qed_get_rdma_ops?: > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style function definition [-Werror=old-style-definition] > > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support") > Signed-off-by: Arnd Bergmann Again, Qlogic folks, please properly review patches posted against your driver. Thanks.