Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753282AbcJMOx5 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 13 Oct 2016 10:53:57 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:33676 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752558AbcJMOxt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Oct 2016 10:53:49 -0400
Date: Thu, 13 Oct 2016 10:53:18 -0400 (EDT)
Message-Id: <20161013.105318.2208635604910378202.davem@davemloft.net>
To: Yuval.Mintz@cavium.com
Cc: arnd@arndb.de, Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com,
        everest-linux-l2@qlogic.com, Ram.Amrani@cavium.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] qed: fix old-style function definition
From: David Miller <davem@davemloft.net>
In-Reply-To: <BL2PR07MB230694B607619C4DFBB90B7F8DDC0@BL2PR07MB2306.namprd07.prod.outlook.com>
References: <20161010115937.730249-1-arnd@arndb.de>
        <20161013.095532.1238800778112994579.davem@davemloft.net>
        <BL2PR07MB230694B607619C4DFBB90B7F8DDC0@BL2PR07MB2306.namprd07.prod.outlook.com>
X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 13 Oct 2016 07:53:20 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9DEs2gP018882
Content-Length: 751
Lines: 21

From: "Mintz, Yuval" <Yuval.Mintz@cavium.com>
Date: Thu, 13 Oct 2016 14:15:51 +0000

>> > The definition of qed_get_rdma_ops() is not a prototype unless we add
>> > 'void' here, as indicated by this W=1 warning:
>> >
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ?qed_get_rdma_ops?:
>> > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style
>> > function definition [-Werror=old-style-definition]
>> >
>> > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support")
>> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> 
>> Again, Qlogic folks, please properly review patches posted against your driver.
>> 
>> Thanks.
> 
> Sorry, managed to miss this one.
> Acked-by: Yuval Mintz <Yuval.Mintz@caviumnetworks.com>

Applied.