Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932255AbcJMPoW (ORCPT ); Thu, 13 Oct 2016 11:44:22 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:58347 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbcJMPoK (ORCPT ); Thu, 13 Oct 2016 11:44:10 -0400 Date: Thu, 13 Oct 2016 17:39:34 +0200 (CEST) From: Thomas Gleixner To: Grzegorz Andrejczuk cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de, dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org, lukasz.daniluk@intel.com, james.h.cownie@intel.com, jacob.jun.pan@intel.com Subject: Re: [PATCH v3 4/4] Add R3MWAIT to CPU features In-Reply-To: <1476367345-25628-5-git-send-email-grzegorz.andrejczuk@intel.com> Message-ID: References: <1476367345-25628-1-git-send-email-grzegorz.andrejczuk@intel.com> <1476367345-25628-5-git-send-email-grzegorz.andrejczuk@intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 576 Lines: 18 On Thu, 13 Oct 2016, Grzegorz Andrejczuk wrote: > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -1108,6 +1108,9 @@ static void identify_cpu(struct cpuinfo_x86 *c) > #endif > /* The boot/hotplug time assigment got cleared, restore it */ > c->logical_proc_id = topology_phys_to_logical_pkg(c->phys_proc_id); > + > + if (cpu_has(c, X86_FEATURE_PHIR3MWAIT)) > + elf_hwcap2 |= HWCAP2_PHIR3MWAIT; Why can't you just set that bit in probe_xeon_phi_r3mwait()? Just because its so much fun to sprinkle code at random places, right? Sigh. tglx