Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756427AbcJMQDa (ORCPT ); Thu, 13 Oct 2016 12:03:30 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:33341 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755163AbcJMQDV (ORCPT ); Thu, 13 Oct 2016 12:03:21 -0400 MIME-Version: 1.0 In-Reply-To: <1476374061-9080-1-git-send-email-toshi.kani@hpe.com> References: <1476374061-9080-1-git-send-email-toshi.kani@hpe.com> From: Dan Williams Date: Thu, 13 Oct 2016 09:01:45 -0700 Message-ID: Subject: Re: [PATCH] pmem: report error on clear poison failure To: Toshi Kani Cc: Vishal L Verma , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 536 Lines: 11 On Thu, Oct 13, 2016 at 8:54 AM, Toshi Kani wrote: > ACPI Clear Uncorrectable Error DSM function may fail or may be > unsupported on a platform. pmem_clear_poison() returns without > clearing badblocks in such cases, which leads to a silent data > corruption. > > Change pmem_do_bvec() and pmem_clear_poison() to return -EIO > so that filesystem can log an error message. What's the silent data corruption scenario? If the clear poison fails I'm assuming that the poison will still be notified on the next read.