Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756821AbcJMQWD (ORCPT ); Thu, 13 Oct 2016 12:22:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48820 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756233AbcJMQV4 (ORCPT ); Thu, 13 Oct 2016 12:21:56 -0400 Date: Thu, 13 Oct 2016 18:21:51 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Jiri Slaby Cc: pbonzini@redhat.com, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] kvm: memset whole irq_eoi Message-ID: <20161013162151.GG30525@potion> References: <20161013154520.29747-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161013154520.29747-1-jslaby@suse.cz> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 13 Oct 2016 16:21:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 39 2016-10-13 17:45+0200, Jiri Slaby: > gcc 7 warns: > arch/x86/kvm/ioapic.c: In function 'kvm_ioapic_reset': > arch/x86/kvm/ioapic.c:597:2: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size] > > And it is right. Memset whole array using sizeof operator. > > Signed-off-by: Jiri Slaby > Cc: Paolo Bonzini > Cc: Radim Krčmář > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: H. Peter Anvin > Cc: x86@kernel.org > Cc: kvm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- Added x86 subject tag and applied to kvm/queue, thanks. > arch/x86/kvm/ioapic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/ioapic.c b/arch/x86/kvm/ioapic.c > index c7220ba94aa7..1a22de70f7f7 100644 > --- a/arch/x86/kvm/ioapic.c > +++ b/arch/x86/kvm/ioapic.c > @@ -594,7 +594,7 @@ static void kvm_ioapic_reset(struct kvm_ioapic *ioapic) > ioapic->irr = 0; > ioapic->irr_delivered = 0; > ioapic->id = 0; > - memset(ioapic->irq_eoi, 0x00, IOAPIC_NUM_PINS); > + memset(ioapic->irq_eoi, 0x00, sizeof(ioapic->irq_eoi)); > rtc_irq_eoi_tracking_reset(ioapic); > } > > -- > 2.10.1 >