Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933535AbcJMQo6 (ORCPT ); Thu, 13 Oct 2016 12:44:58 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:33802 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933418AbcJMQoj (ORCPT ); Thu, 13 Oct 2016 12:44:39 -0400 Subject: Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes To: Jean Delvare References: <20161011172441.7422-1-palminha@synopsys.com> <20161013134029.1828048b@endymion> CC: , , From: Carlos Palminha Message-ID: <57FFB9D9.7020903@synopsys.com> Date: Thu, 13 Oct 2016 17:44:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20161013134029.1828048b@endymion> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.25.118] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1063 Lines: 31 Hi Jean, On 13-10-2016 12:40, Jean Delvare wrote: > Hi Carlos, > > On Tue, 11 Oct 2016 18:24:36 +0100, Carlos Palminha wrote: >> This patchset fixes several coding style issues. >> >> Carlos Palminha (5): >> i2c: i2c-piix4: coding style fix - '*' adjacent to data name >> i2c: i2c-piix4: coding style fix - assignment in if condition >> i2c: i2c-piix4: coding style fix - long comments blocks >> i2c: i2c-piix4: coding style fix - spaces with open parenthesis >> i2c: i2c-piix4: coding style fix - quoted string split across lines >> >> drivers/i2c/busses/i2c-piix4.c | 144 +++++++++++++++++++++++------------------ >> 1 file changed, 82 insertions(+), 62 deletions(-) > > Except for the two issues which were already pointed out, I'm fine with > these changes, however there is no good reason to split them into 5 > separate patches. Fixing the coding style is one goal, it should be all > done with a single patch. So, when you resubmit, please do so as a > single patch. > > Thanks, > Sure... I'll resubmit as one patch. Regards, C.Palminha