Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933918AbcJMQ6Q (ORCPT ); Thu, 13 Oct 2016 12:58:16 -0400 Received: from mout.web.de ([212.227.15.4]:62050 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbcJMQ55 (ORCPT ); Thu, 13 Oct 2016 12:57:57 -0400 Subject: [PATCH 17/18] [media] RedRat3: Adjust two checks for null pointers in redrat3_dev_probe() To: linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , Sean Young , Wolfram Sang References: <566ABCD9.1060404@users.sourceforge.net> <81cef537-4ad0-3a74-8bde-94707dcd03f4@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <810dec6f-8c5e-6784-bdc0-a9bed477b8c4@users.sourceforge.net> Date: Thu, 13 Oct 2016 18:47:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <81cef537-4ad0-3a74-8bde-94707dcd03f4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:zl1v6DBeurHgJdezIFZaFQOrsFLabflNkFLl/mkDcrOJaeJvzQB rZc5qRNLdeqhspfiBNajlzmMIcsKCCOUU5dDYZko3HeP7ksgPlpsv4YwIXG4NcyrVVKjT1b 5UZ7qEwXFPdxrNThFl+IoCqX18p4CJQMQet7ND0NOOEf1E0wL7ib4XefRY4upWgP20ms8Z3 YrTr7O1bRcDkF28L5xGRg== X-UI-Out-Filterresults: notjunk:1;V01:K0:VcH8lgxTAn4=:eJ62aiC3xQPMR5kVkuqUTL 8rn4tO70rjYytWVKO1DZxctxQ0nCdRa3LpKRaCMAdK708XewsTHs0w3ljxGyJp8rSshbhGGZO Cby1v2p7Iwijqocsi/PmvYgYbMebV8tuUQVO/Bo7uLEneASMd9bdqoWdmyeDcKL1EU6G7Mt27 J+Tbp2jXFRWOMnGjeV5b+iNCS1Ca1YZyTWXp+9AITB8xtftGaAewfljcelxTGqKIW9fLcc0PB D4BGzhxD8EUwMf8pQzBO0INUhqAI2vWFYlaZ0sXXCOQonvxUhKRdBvihSB56vb86s+LdisFdx 2O4yTIFjt/0dyKqciAkaFiIV/Vu6w2I48hFQJ6QGNz0o2C04iqrQVz3GdJUGrn1tdHOeCl2l1 /CCBC19CQAYxsfSpn1hD4GBhrAuz5IBqpQsOFTu6IxVrC+wf9fbglH12Ua2FeXsGnaFO8BW7V VyBffXhoZtIJxWj6LpNSyf6KkFbArtxF6QAZIpjG2pMnVIsoe3i56+51yJEppLjw+dn9hdbvk xdXEl3fNIGg/f8YTCYRt4s3TpUuW7Be7t4f08MPtMtET5EgyYaemHgA9s4HXttYTU2RWvbCFE MMiOmsfr4yCgblfWwog2nNc+HhGL8PTwaM+gecLP305XYq/+3hbpiZER6HBLCLpMLTzEKwyyh Re20vOHy3gcxWReQLzXk70rpSWZ+MWgeXaYCEYjViXXUhxrvfQxoeLPffGn3x36drxpHnjWaJ 27LhYIlGu0tXq7I1STXPexOvngLHIiqq3zTBoXocK/n0xGW+kb6QWiq17cu3An/yhhqp055jX 6cT8ifc Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 42 From: Markus Elfring Date: Thu, 13 Oct 2016 17:40:34 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/media/rc/redrat3.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c index 06c9eea..a09d5cb 100644 --- a/drivers/media/rc/redrat3.c +++ b/drivers/media/rc/redrat3.c @@ -923,8 +923,7 @@ static int redrat3_dev_probe(struct usb_interface *intf, ep = &uhi->endpoint[i].desc; addr = ep->bEndpointAddress; attrs = ep->bmAttributes; - - if ((ep_in == NULL) && + if (!ep_in && ((addr & USB_ENDPOINT_DIR_MASK) == USB_DIR_IN) && ((attrs & USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_BULK)) { @@ -935,7 +934,7 @@ static int redrat3_dev_probe(struct usb_interface *intf, ep_in = ep; } - if ((ep_out == NULL) && + if (!ep_out && ((addr & USB_ENDPOINT_DIR_MASK) == USB_DIR_OUT) && ((attrs & USB_ENDPOINT_XFERTYPE_MASK) == USB_ENDPOINT_XFER_BULK)) { -- 2.10.1