Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934785AbcJMSPY (ORCPT ); Thu, 13 Oct 2016 14:15:24 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:32900 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932982AbcJMSPP (ORCPT ); Thu, 13 Oct 2016 14:15:15 -0400 From: Tai Nguyen To: mark.rutland@arm.com, dan.carpenter@oracle.com, will.deacon@arm.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tai Nguyen Subject: [PATCH v2] perf: xgene: Remove bogus IS_ERR() check Date: Thu, 13 Oct 2016 11:09:16 -0700 Message-Id: <1476382156-11641-1-git-send-email-ttnguyen@apm.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 36 In acpi_get_pmu_hw_inf we pass the address of a local variable to IS_ERR(), which doesn't make sense, as the pointer must be a real, valid pointer. This doesn't cause a functional problem, as IS_ERR() will evaluate as false, but the check is bogus and causes static checkers to complain. Remove the bogus check. The bug is reported by Dan Carpenter in [1] [1] https://www.spinics.net/lists/arm-kernel/msg535957.html Signed-off-by: Tai Nguyen Acked-by: Mark Rutland --- v2: Add more problem description in the commit message Add Acked-by: Mark Rutland drivers/perf/xgene_pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c index c2ac764..a8ac4bc 100644 --- a/drivers/perf/xgene_pmu.c +++ b/drivers/perf/xgene_pmu.c @@ -1011,7 +1011,7 @@ xgene_pmu_dev_ctx *acpi_get_pmu_hw_inf(struct xgene_pmu *xgene_pmu, rc = acpi_dev_get_resources(adev, &resource_list, acpi_pmu_dev_add_resource, &res); acpi_dev_free_resource_list(&resource_list); - if (rc < 0 || IS_ERR(&res)) { + if (rc < 0) { dev_err(dev, "PMU type %d: No resource address found\n", type); goto err; } -- 1.9.1