Date: Thu, 13 Oct 2016 19:18:37 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tai Nguyen <ttnguyen@apm.com>
Cc: mark.rutland@arm.com, dan.carpenter@oracle.com, will.deacon@arm.com,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] perf: xgene: Remove bogus IS_ERR() check
Message-ID: <20161013181837.GQ19539@ZenIV.linux.org.uk>
References: <1476382156-11641-1-git-send-email-ttnguyen@apm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1476382156-11641-1-git-send-email-ttnguyen@apm.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 473
Lines: 8

On Thu, Oct 13, 2016 at 11:09:16AM -0700, Tai Nguyen wrote:
> In acpi_get_pmu_hw_inf we pass the address of a local variable to IS_ERR(),
> which doesn't make sense, as the pointer must be a real, valid pointer.
> This doesn't cause a functional problem, as IS_ERR() will evaluate as
> false, but the check is bogus and causes static checkers to complain.

... unless the test is actually a misspelled IS_ERR(res) and the current
code is broken by effectively skipping it.