From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
        "vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Subject: Re: [PATCH] pmem: report error on clear poison failure
Thread-Topic: [PATCH] pmem: report error on clear poison failure
Thread-Index: AQHSJWpbK8SDkE3LT06eGc6/iqHfVaCmi1yAgAABUIA=
Date: Thu, 13 Oct 2016 16:08:02 +0000
Message-ID: <1476374787.20881.34.camel@hpe.com>
References: <1476374061-9080-1-git-send-email-toshi.kani@hpe.com>
         <CAPcyv4jdRhM8r1Ut4Ls4a4_PTroiXXZVcvruJ9TEj_SifenBCw@mail.gmail.com>
In-Reply-To: <CAPcyv4jdRhM8r1Ut4Ls4a4_PTroiXXZVcvruJ9TEj_SifenBCw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <D027AC5394CAF041AA3A22D7A3677681@NAMPRD84.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2016 16:08:02.5004
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0008
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9DIiTiG020213
Content-Length: 802
Lines: 22

On Thu, 2016-10-13 at 09:01 -0700, Dan Williams wrote:
> On Thu, Oct 13, 2016 at 8:54 AM, Toshi Kani <toshi.kani@hpe.com>
> wrote:
> > 
> > ACPI Clear Uncorrectable Error DSM function may fail or may be
> > unsupported on a platform.  pmem_clear_poison() returns without
> > clearing badblocks in such cases, which leads to a silent data
> > corruption.
> > 
> > Change pmem_do_bvec() and pmem_clear_poison() to return -EIO
> > so that filesystem can log an error message.
> 
> What's the silent data corruption scenario?  If the clear poison
> fails I'm assuming that the poison will still be notified on the next
> read.

I agree that the data is eventually read, but there is no guranteed
that when it is read soon enough, i.e. user might not access to the
data for a long time.

Thanks,
-Toshi