Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934231AbcJMTZy (ORCPT ); Thu, 13 Oct 2016 15:25:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50101 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934104AbcJMTZu (ORCPT ); Thu, 13 Oct 2016 15:25:50 -0400 Date: Thu, 13 Oct 2016 21:18:48 +0200 From: Greg KH To: Nadim Almas Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue Message-ID: <20161013191848.GA22050@kroah.com> References: <20161013160557.GA4407@gmail.com> <20161013162115.GA14136@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 887 Lines: 29 Note, the mailing lists reject html email, please fix up your client. On Fri, Oct 14, 2016 at 12:34:30AM +0530, Nadim Almas wrote: > But i have seen in some place where comments are below the line > like in > here from "drivers/staging/ks7010/eap_packet.h" > ?line number 100 > > > ?struct wpa_eapol_key { > unsigned char type; > unsigned short key_info; > unsigned short key_length; > unsigned char replay_counter[WPA_REPLAY_COUNTER_LEN]; > unsigned char key_nonce[WPA_NONCE_LEN]; > unsigned char key_iv[16]; > unsigned char key_rsc[8]; > unsigned char key_id[8]; /* Reserved in IEEE 802.11i/RSN */ > unsigned char key_mic[16]; > unsigned short key_data_length; > /* followed by key_data_length bytes of key_data */ > } __packed; Read that comment, it makes sense to be there, right? Because it describes the field after the one above it. Thanks for proving my point :) greg k-h