Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbcJMTtC (ORCPT ); Thu, 13 Oct 2016 15:49:02 -0400 Received: from 216-12-86-13.cv.mvl.ntelos.net ([216.12.86.13]:55982 "EHLO brightrain.aerifal.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750764AbcJMTsx (ORCPT ); Thu, 13 Oct 2016 15:48:53 -0400 Date: Thu, 13 Oct 2016 15:48:47 -0400 From: Rich Felker To: Daniel Lezcano Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, Rob Herring , Mark Rutland , Thomas Gleixner , "Paul E. McKenney" Subject: Re: [PATCH v8 2/2] clocksource: add J-Core timer/clocksource driver Message-ID: <20161013194847.GX19318@brightrain.aerifal.cx> References: <588ea0a3175fcf5d409ca32249f24760f2f6f839.1475990489.git.dalias@libc.org> <20161011181812.GA1697@mai> <20161011202850.GK19318@brightrain.aerifal.cx> <20161012092711.GC1697@mai> <20161012170236.GP19318@brightrain.aerifal.cx> <20161012213126.GA1508@mai> <20161013192542.GW19318@brightrain.aerifal.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161013192542.GW19318@brightrain.aerifal.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 33 On Thu, Oct 13, 2016 at 03:25:42PM -0400, Rich Felker wrote: > On Wed, Oct 12, 2016 at 11:31:26PM +0200, Daniel Lezcano wrote: > > > > --> System Type > > > > > > > > That is what you are looking for, a SUPERH config option selecting all the > > > > common options and then a JCORE config option adding the different missing > > > > bits, namely the CLKSRC_JCORE_PIT. > > > > > > We do have something like "system type" in arch/sh, and it's what I'm > > > trying to deprecate since it's the switch to select between all the > > > hard-coded board files, _or_ device tree. > > > > > > Since part of the goal of my DT overhaul is to be able (but not > > > forced) to produce kernels that run on a wide range of hardware, > > > rather than having a "system type (select one)" option, what about > > > individual boolean options like: > > > > > > config JCORE_SOC > > > bool "Support for J-Core SoCs" > > > select CLKSRC_JCORE_PIT > > > select JCORE_AIC > > > ... > > > > I'm perfectly fine with this. > > Does this adequately ensure that dependencies for the clocksource and > irq driver are met? If not, what else do I need to do? I've checked and it seems the dependencies are always met for arch/sh, at least with device tree enabled (on which JCORE_SOC will depend), so it shouldn't matter. Rich