Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756502AbcJMXiE (ORCPT ); Thu, 13 Oct 2016 19:38:04 -0400 Received: from mx0a-00003501.pphosted.com ([67.231.144.15]:58973 "EHLO mx0a-000cda01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756047AbcJMXhp (ORCPT ); Thu, 13 Oct 2016 19:37:45 -0400 Authentication-Results: seagate.com; dkim=pass header.s="google" header.d=seagate.com MIME-Version: 1.0 In-Reply-To: <1476399631-5799-3-git-send-email-adam.manzanares@hgst.com> References: <1476399631-5799-1-git-send-email-adam.manzanares@hgst.com> <1476399631-5799-3-git-send-email-adam.manzanares@hgst.com> From: Shaun Tancheff Date: Thu, 13 Oct 2016 18:36:32 -0500 Message-ID: Subject: Re: [PATCH v5 2/4] fusion: remove iopriority handling To: Adam Manzanares Cc: Jens Axboe , Tejun Heo , Dan Williams , Hannes Reinecke , "Martin K. Petersen" , Mike Christie , Toshi Kani , Ming Lei , Sathya Prakash , chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, LKML , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, Adam Manzanares Content-Type: text/plain; charset=UTF-8 X-Proofpoint-PolicyRoute: Outbound X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-13_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=6 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610130396 X-Proofpoint-Spam-Policy: Default Domain Policy Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9DNcIuF021217 Content-Length: 1925 Lines: 42 On Thu, Oct 13, 2016 at 6:00 PM, Adam Manzanares wrote: > The request priority is now by default coming from the ioc. It was not > clear what this code was trying to do based upon the iopriority class or > data. The driver should check that a device supports priorities and use > them according to the specificiations of ioprio. > > Signed-off-by: Adam Manzanares > --- > drivers/message/fusion/mptscsih.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c > index 6c9fc11..4740bb6 100644 > --- a/drivers/message/fusion/mptscsih.c > +++ b/drivers/message/fusion/mptscsih.c > @@ -1369,11 +1369,6 @@ mptscsih_qcmd(struct scsi_cmnd *SCpnt) > if ((vdevice->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES) > && (SCpnt->device->tagged_supported)) { > scsictl = scsidir | MPI_SCSIIO_CONTROL_SIMPLEQ; > - if (SCpnt->request && SCpnt->request->ioprio) { > - if (((SCpnt->request->ioprio & 0x7) == 1) || > - !(SCpnt->request->ioprio & 0x7)) > - scsictl |= MPI_SCSIIO_CONTROL_HEADOFQ; > - } > } else > scsictl = scsidir | MPI_SCSIIO_CONTROL_UNTAGGED; Style wise you can further remove the extra parens around SCpnt->device->tagged_supported As well as the now redundant braces. Regards, Shaun > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-block" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DQIBAg&c=IGDlg0lD0b-nebmJJ0Kp8A&r=Wg5NqlNlVTT7Ugl8V50qIHLe856QW0qfG3WVYGOrWzA&m=ZE7JzxXeXPEWqk9WYm42hZHj8gESRg1QoS5XklfbprM&s=C0iMyTgYbYl06F1SQ2DqfdESKBtl3Whp5rSnHSBXOc4&e=