Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932408AbcJMXiY (ORCPT ); Thu, 13 Oct 2016 19:38:24 -0400 Received: from mail-pa0-f66.google.com ([209.85.220.66]:35276 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbcJMXhq (ORCPT ); Thu, 13 Oct 2016 19:37:46 -0400 Date: Thu, 13 Oct 2016 19:22:30 -0400 From: Tejun Heo To: Adam Manzanares Cc: axboe@kernel.dk, dan.j.williams@intel.com, hare@suse.de, martin.petersen@oracle.com, mchristi@redhat.com, toshi.kani@hpe.com, ming.lei@canonical.com, sathya.prakash@broadcom.com, chaitra.basappa@broadcom.com, suganath-prabu.subramani@broadcom.com, linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, Adam Manzanares Subject: Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default Message-ID: <20161013232230.GB32534@mtj.duckdns.org> References: <1476399631-5799-1-git-send-email-adam.manzanares@hgst.com> <1476399631-5799-5-git-send-email-adam.manzanares@hgst.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476399631-5799-5-git-send-email-adam.manzanares@hgst.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 443 Lines: 17 Hello, Adam. Sorry about late reply. Was on vacation. On Thu, Oct 13, 2016 at 04:00:31PM -0700, Adam Manzanares wrote: > Add a sysfs entry to turn on priority information being passed > to a ATA device. By default this feature is turned off. > > This patch depends on ata: Enabling ATA Command Priorities Looks generally good but can we please use a device attribute name which is more specific - ie. enable_ncq_prio? Thanks. -- tejun