DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; 
  s=zapps768; d=zoho.com; 
  h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; 
  b=cTpymXosYDPmyBhFgEuLQCDVi233IrFIBwVN7fWiS9gYf1ePJvno28ma+spZ6WaXXAhRTlx3ZGA7
    QNKFsxTC2ANrB/on+qxN+rtDiJTiUgB68m22o4kurBUjd3D0yCZz  
Subject: Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm
To: Tejun Heo <tj@kernel.org>
References: <701fa92a-026b-f30b-833c-a5e61eab6549@zoho.com>
 <20161013233722.GF32534@mtj.duckdns.org>
Cc: zijun_hu@htc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        akpm@linux-foundation.org, cl@linux.com
From: zijun_hu <zijun_hu@zoho.com>
Message-ID: <b1e98606-be69-0dd6-0a50-1b19e6237dc5@zoho.com>
Date: Fri, 14 Oct 2016 07:49:44 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20161013233722.GF32534@mtj.duckdns.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 922
Lines: 21

On 2016/10/14 7:37, Tejun Heo wrote:
> Hello, Zijun.
> 
> On Tue, Oct 11, 2016 at 08:48:45PM +0800, zijun_hu wrote:
>> compared with the original algorithm theoretically and practically, the
>> new one educes the same grouping results, besides, it is more effective,
>> simpler and easier to understand.
> 
> If the original code wasn't broken and the new code produces the same
> output, I'd really not mess with this code.  There simply is no upside
> to messing with this code.  It's run once during boot and never a
> noticeable contributor of boot overhead.  Maybe the new code is a bit
> simpler and more efficient but the actual benefit is so small that any
> risk would outweigh it.
> 
> Thanks.
>
the main intent of this change is making the CPU grouping algorithm more
easily to understand, especially, for newcomer for memory managements
take me as a example, i really take me a longer timer to understand it