Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756844AbcJMXv6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 13 Oct 2016 19:51:58 -0400
Received: from mail-oi0-f47.google.com ([209.85.218.47]:35709 "EHLO
        mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753550AbcJMXv3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Oct 2016 19:51:29 -0400
MIME-Version: 1.0
In-Reply-To: <1476401397-26497-3-git-send-email-john.stultz@linaro.org>
References: <1476401397-26497-1-git-send-email-john.stultz@linaro.org> <1476401397-26497-3-git-send-email-john.stultz@linaro.org>
From: John Stultz <john.stultz@linaro.org>
Date: Thu, 13 Oct 2016 16:51:26 -0700
Message-ID: <CALAqxLVF3XNVQ9Z3DWy83dQVZGOiWRKhTgm6E7uo_Ob9VtoWtA@mail.gmail.com>
Subject: Re: [RFC][PATCH 2/2] usb: dwc2: Add a quirk to allow speed
 negotiation for Hisilicon Hi6220
To: lkml <linux-kernel@vger.kernel.org>
Cc: Chen Yu <chenyu56@huawei.com>, Wei Xu <xuwei5@hisilicon.com>,
        Guodong Xu <guodong.xu@linaro.org>,
        Amit Pundir <amit.pundir@linaro.org>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, John Youn <johnyoun@synopsys.com>,
        Douglas Anderson <dianders@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, John Stultz <john.stultz@linaro.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1872
Lines: 45

On Thu, Oct 13, 2016 at 4:29 PM, John Stultz <john.stultz@linaro.org> wrote:
> From: Chen Yu <chenyu56@huawei.com>
>
> The Hi6220's usb controller is limited in that it does not
> automatically autonegotiate the usb speed. Thus it requires a
> quirk so that we can manually negotiate the best usb speed for
> the attached device.
>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Guodong Xu <guodong.xu@linaro.org>
> Cc: Amit Pundir <amit.pundir@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: John Youn <johnyoun@synopsys.com>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Chen Yu <chenyu56@huawei.com>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi |  1 +
>  drivers/usb/dwc2/core.h                   |  7 +++
>  drivers/usb/dwc2/hcd.c                    | 75 +++++++++++++++++++++++++++++++
>  drivers/usb/dwc2/platform.c               |  3 ++
>  4 files changed, 86 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 17839db..2c8f435 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -752,6 +752,7 @@
>                         g-np-tx-fifo-size = <128>;
>                         g-tx-fifo-size = <128 128 128 128 128 128>;
>                         interrupts = <0 77 0x4>;
> +                       hi6220,change_speed_quirk;


I also realize I'm missing the DT binding documentation for this, but
I wanted to get a rough idea if this approach was ok first.
On the next submission (if there aren't major objections to the
approach) I can split the binding documentation and dts change into
different patches.

thanks
-john