Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756391AbcJNAA1 (ORCPT ); Thu, 13 Oct 2016 20:00:27 -0400 Received: from mail-co1nam03on0073.outbound.protection.outlook.com ([104.47.40.73]:51264 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753188AbcJNAAX (ORCPT ); Thu, 13 Oct 2016 20:00:23 -0400 X-Greylist: delayed 25599 seconds by postgrey-1.27 at vger.kernel.org; Thu, 13 Oct 2016 20:00:22 EDT From: "Mintz, Yuval" To: David Miller , "arnd@arndb.de" CC: "Yuval.Mintz@qlogic.com" , "Ariel.Elior@qlogic.com" , "everest-linux-l2@qlogic.com" , "Amrani, Ram" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] qed: fix old-style function definition Thread-Topic: [PATCH] qed: fix old-style function definition Thread-Index: AQHSIu3T9dvuSVAhMka+SkU6XZ8jBKCmbREAgAAFgVA= Date: Thu, 13 Oct 2016 14:15:51 +0000 Message-ID: References: <20161010115937.730249-1-arnd@arndb.de> <20161013.095532.1238800778112994579.davem@davemloft.net> In-Reply-To: <20161013.095532.1238800778112994579.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuval.Mintz@cavium.com; x-originating-ip: [31.168.140.228] x-ms-office365-filtering-correlation-id: 7dbd1538-1e01-4038-b7a9-08d3f3737086 x-microsoft-exchange-diagnostics: 1;CY1PR07MB2199;6:FuzA1d6GtHRgJnnpJRbI22I3np4AFB9zS3TrBW35BP12+kISw6rYdQEAzItq5Gim+k+OwsQm7B9aWbG0QarCAtZqdKBvc0BIOL7b7cbF+qg2Q7H5D+t4HN3Bhbvhhdqun0mVMOcAfFbN7Nb0rbZFFZsUgOW8XNaUVf9Xbw7UQeE+x7AdqUm1WZZo26m2BwEwvz3GAnK6JY6ejXCwhn2le+6OxqsbysAG2Zw2RsSKZCykzIvJ9SMrY6rOfRYCWzw1CNsmzunP8AHGxI3sTbkO16jBr6soqOf+4kKINWcJi3ZzkWCswXSIpNXN48pcqKzJ;5:CuFelpgVVw9m+7wq4g6dEsohJyWK3A5/hif59YW4D+WxbLruCVfzQ46OXA2BzobGFAAwt/BJJgxQqphPU6EbggHfFiut48zFY5c+quaSsJa/h6trIIWCZSr9WZ5xUeyerMFHGAQKGEy2Rj6POumYPbe89sIvQpcicdJg8LL96LI=;24:RqBghinuFm3fWnoq039bTxisdz+r0kZ/a/W3BMSv6bbs72iJG+PgSSjYl+5JOeAR1mqrrB0INzOsaE49Io9iEsUVYCQU/v2EXePPrys0HcI=;7:nFcHpPQ9j18kRGKlxPlJO/aPwJsO/6DMBovCNlRD0ESSw7UT2qrqHD/FqpnLQrsc64P1Xt7WnYioWV/MCm0Fe5Gm4eAungapxFHhAfDB8CZ6kg7Czkmzu88edyckTJttzVsQ3h5H7cTLqBiCW6bR32nptSTwARGW8uz5XG0+uVdCzi2yVAalHdPno7mZnyj3VkdIb9mFl603JbBjHY+ZJlZvLo1WF+ZI/ks2iyI8N5oiATljQ9+ykOTfmplMpKzGlEZC/K+lGr6lC3ptD5x2Jib21B9dxNDVKaxvwGjBHJclcrzYA1dPM2RQYgn1ss6ZN2z3fgmuPb9FHjNYeAz56Fv5AWWafQB6henpB0/J4ic= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2199; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CY1PR07MB2199;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2199; x-forefront-prvs: 0094E3478A x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(199003)(189002)(5002640100001)(122556002)(86362001)(5660300001)(102836003)(3846002)(6116002)(2950100002)(2501003)(66066001)(10400500002)(81166006)(81156014)(92566002)(54356999)(9686002)(76576001)(7696004)(76176999)(33656002)(68736007)(4326007)(8676002)(50986999)(3660700001)(19580405001)(87936001)(19580395003)(3280700002)(101416001)(2906002)(305945005)(189998001)(586003)(77096005)(7736002)(106116001)(5001770100001)(106356001)(74316002)(97736004)(105586002)(99286002)(2900100001)(8936002)(7846002)(11100500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2199;H:BL2PR07MB2306.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-7" MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2016 14:15:52.1255 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2199 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u9E00iQG021291 Content-Length: 637 Lines: 16 > > The definition of qed_get_rdma_ops() is not a prototype unless we add > > 'void' here, as indicated by this W=1 warning: > > > > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ?qed_get_rdma_ops?: > > drivers/net/ethernet/qlogic/qed/qed_roce.c:2950:28: error: old-style > > function definition [-Werror=old-style-definition] > > > > Fixes: abd49676c707 ("qed: Add RoCE ll2 & GSI support") > > Signed-off-by: Arnd Bergmann > > Again, Qlogic folks, please properly review patches posted against your driver. > > Thanks. Sorry, managed to miss this one. Acked-by: Yuval Mintz