Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757411AbcJNBSX (ORCPT ); Thu, 13 Oct 2016 21:18:23 -0400 Received: from sender153-mail.zoho.com ([74.201.84.153]:25355 "EHLO sender153-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757248AbcJNBSO (ORCPT ); Thu, 13 Oct 2016 21:18:14 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=subject:to:references:cc:from:message-id:date:user-agent:mime-version:in-reply-to:content-type; b=GKcuNa6I50SnDwu1i9RbEbCNtuQWGXg1pwsyi9ldQopzlqd132L6he39YHcat02tyWjCzvLTYcu8 jKwdux66tiW1na1eBV/ir6Nysdq1ox6mEAiSGhOA2QIHuRLs9RIh Subject: Re: [RFC v2 PATCH] mm/percpu.c: simplify grouping CPU algorithm To: Tejun Heo References: <701fa92a-026b-f30b-833c-a5e61eab6549@zoho.com> <20161013233722.GF32534@mtj.duckdns.org> <20161014003313.GI32534@mtj.duckdns.org> Cc: zijun_hu@htc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, cl@linux.com From: zijun_hu Message-ID: <62b744a3-4206-a25e-b8eb-1fd18953b4f3@zoho.com> Date: Fri, 14 Oct 2016 09:17:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161014003313.GI32534@mtj.duckdns.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 576 Lines: 16 On 2016/10/14 8:33, Tejun Heo wrote: > Hello, > > On Fri, Oct 14, 2016 at 07:49:44AM +0800, zijun_hu wrote: >> the main intent of this change is making the CPU grouping algorithm more >> easily to understand, especially, for newcomer for memory managements >> take me as a example, i really take me a longer timer to understand it > > If the new code is easier to understand, it's only so marginally. It > just isn't worth the effort or risk. > > Thanks. > okay i agree with your opinion. but i am sure this changes don't have any risk after tests and theoretic analyse