MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Fri, 14 Oct 2016 11:40:50 +0800
From: xiaogang@codeaurora.org
To: John Stultz <john.stultz@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>, Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Andy Yan <andy.yan@rock-chips.com>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Nicolas Ferre <nicolas.ferre@atmel.com>,
        Chris Brand <chris.brand@broadcom.com>,
        Richard Weinberger <richard@nod.at>,
        Moritz Fischer <moritz.fischer@ettus.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS" 
        <linux-pm@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] power: reset: Add qcom reboot mode driver
In-Reply-To: <CALAqxLXL+AHwchp8Ja2NAXt-=0xd87ojA4AGzT-n0oQFbwcCzw@mail.gmail.com>
References: <1476410823-8912-1-git-send-email-xiaogang@codeaurora.org>
 <CALAqxLXL+AHwchp8Ja2NAXt-=0xd87ojA4AGzT-n0oQFbwcCzw@mail.gmail.com>
Message-ID: <ab76bb8e9a3eb417ea2fbfb0363bdc7e@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2131
Lines: 60

在 2016-10-14 11:25，John Stultz 写道：
> On Thu, Oct 13, 2016 at 7:02 PM, Xiaogang Cui <xiaogang@codeaurora.org> 
> wrote:
>> This is a initial version so it's very similar with syscon
>> reboot mode driver. We will add more functionalities in the
>> further after dependency is ready.
>> 
>> Signed-off-by: Xiaogang Cui <xiaogang@codeaurora.org>
>> ---
>>  .../bindings/power_supply/qcom-reboot-mode.txt     |  23 +++++
>>  drivers/power/reset/Kconfig                        |  10 ++
>>  drivers/power/reset/Makefile                       |   1 +
>>  drivers/power/reset/qcom-reboot-mode.c             | 109 
>> +++++++++++++++++++++
>>  4 files changed, 143 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/power_supply/qcom-reboot-mode.txt
>>  create mode 100644 drivers/power/reset/qcom-reboot-mode.c
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/power_supply/qcom-reboot-mode.txt 
>> b/Documentation/devicetree/bindings/power_supply/qcom-reboot-mode.txt
>> new file mode 100644
>> index 0000000..8b33592
>> --- /dev/null
>> +++ 
>> b/Documentation/devicetree/bindings/power_supply/qcom-reboot-mode.txt
>> @@ -0,0 +1,23 @@
>> +Qualcomm Reboot Mode Driver
>> +
>> +Qualcomm reboot mode driver based on reboot mode framework to update
>> +SPMI specific bits.
>> +
>> +Required Properties:
>> +-compatible: "qcom,reboot-mode"
>> +-offset: offset of the SPMI reboot mode register
>> +
>> +Optional Properties:
>> +-mask: mask of reboot mode
>> +-mode-xxx: magic of reboot mode
>> +
>> +Example:
>> +       qcom,reboot-mode@88f {
>> +               compatible = "qcom,reboot-mode";
>> +               offset = <0x88f>;
>> +               mode-normal = <0x00>;
>> +               mode-recovery = <0x04>;
>> +               mode-bootloader = <0x08>;
>> +               mode-rtc = <0x0C>;
> 
> So I don't think we've had a "rtc" mode before. This needs to be very
> clearly documented (or maybe just skipped) so we don't start fraying
> with all the various vendor specific modes.
> 

Thanks for the comments, I will skip this specific mode in next version 
of this patch.

> thanks
> -john