Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754986AbcJNEEl (ORCPT ); Fri, 14 Oct 2016 00:04:41 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:33109 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbcJNEEb (ORCPT ); Fri, 14 Oct 2016 00:04:31 -0400 MIME-Version: 1.0 In-Reply-To: <20161013143751.GE31239@veci.piliscsaba.szeredi.hu> References: <20161013143751.GE31239@veci.piliscsaba.szeredi.hu> From: Linus Torvalds Date: Thu, 13 Oct 2016 21:03:23 -0700 X-Google-Sender-Auth: UtzG2EHSM8-QbedYG-p-E-P8vTQ Message-ID: Subject: Re: [GIT PULL] overlayfs update for 4.9 To: Miklos Szeredi Cc: Al Viro , Linux Kernel Mailing List , linux-fsdevel , linux-unionfs@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 615 Lines: 18 On Thu, Oct 13, 2016 at 7:37 AM, Miklos Szeredi wrote: > > Please pull from: No. Or rather, I pulled and then immediately unpulled. When I look at the diff, I saw an obvious bug in the very first chunk. I'm not going to pull something that is this obviously buggy and untested. Your change to fs/ioctl.c to add a -EXDEV error case very clearly leaks a reference to 'src_file'. It's too late in the merge window for this to be fixed up any more. This has been a painful enough merge window for me that I'm not going to play around with obviously buggy pull requests. Linus