Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754091AbcJNFSi (ORCPT ); Fri, 14 Oct 2016 01:18:38 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34491 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbcJNFS2 (ORCPT ); Fri, 14 Oct 2016 01:18:28 -0400 Date: Thu, 13 Oct 2016 22:18:25 -0700 From: Edward Lipinsky To: Mike Rapoport Cc: Greg KH , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, sudip@vectorindia.org, teddy.wang@siliconmotion.com, linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com Subject: Re: [PATCH] staging: sm750fb: Fix printk() style warning Message-ID: <20161014051825.GA22102@gmail.com> References: <20161002180505.GA19813@gmail.com> <20161002181301.GA22637@kroah.com> <20161007042736.GA18046@gmail.com> <20161007091204.GA29629@rapoport-lnx> <20161010143146.GA8218@gmail.com> <20161013143922.GA17656@rapoport-lnx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161013143922.GA17656@rapoport-lnx> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 23 On Thu, Oct 13, 2016 at 05:39:22PM +0300, Mike Rapoport wrote: > On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote: > > > > Thanks, that makes sense. I tried deleting the if statement and printk() > > from ddk750_help.c, and adding the following in lynxfb_pci_probe() after > > calling hw_sm750_map() and checking for errors: > > > > if (sm750_dev->revid == 0xfe) > > dev_info(&pdev->dev, "found sm750le\n"); > > > > The driver compiles, loads and unloads ok with this code. > > > > Does this look correct? > > Yep, seems just right. > > > Regards, > > Ed L. Good, thanks. I will submit an updated patch. Regards, Ed L.