Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757324AbcJNGk6 (ORCPT ); Fri, 14 Oct 2016 02:40:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:32892 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754536AbcJNGku (ORCPT ); Fri, 14 Oct 2016 02:40:50 -0400 Date: Fri, 14 Oct 2016 08:32:51 +0200 From: Greg KH To: Nadim Almas Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue Message-ID: <20161014063251.GA29252@kroah.com> References: <20161013195517.GA18229@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161013195517.GA18229@gmail.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 33 On Fri, Oct 14, 2016 at 01:25:17AM +0530, Nadim Almas wrote: > Fixed coding style issue Why the indentation? > > Signed-off-by: Nadim Almas > --- > Changes in v2: > -Comment is taken from below line. Huh? > > drivers/staging/ks7010/eap_packet.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h > index df7f760..90432ff 100644 > --- a/drivers/staging/ks7010/eap_packet.h > +++ b/drivers/staging/ks7010/eap_packet.h > @@ -58,11 +58,13 @@ struct ieee802_1x_eapol_key { > * encrypt the Key field; 64-bit NTP timestamp MAY be used here > */ > unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN]; > - unsigned char key_iv[IEEE8021X_KEY_IV_LEN]; /* cryptographically random number */ > + unsigned char key_iv[IEEE8021X_KEY_IV_LEN]; > + /* cryptographically random number */ Again, you put this below the line, which is not ok at all. Does this seem to be the way you would normally read code? greg k-h