Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757422AbcJNHIx (ORCPT ); Fri, 14 Oct 2016 03:08:53 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:58009 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757381AbcJNHIu (ORCPT ); Fri, 14 Oct 2016 03:08:50 -0400 Date: Fri, 14 Oct 2016 09:08:25 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Carlos Palminha Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: i2c-piix4: several coding style fixes Message-ID: <20161014070825.qlawh2ttlwj24jge@pengutronix.de> References: <20161013223901.16460-1-palminha@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161013223901.16460-1-palminha@synopsys.com> User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 22 Hello, On Thu, Oct 13, 2016 at 11:39:01PM +0100, Carlos Palminha wrote: > @@ -196,7 +204,7 @@ static int piix4_setup(struct pci_dev *PIIX4_dev, > } else { > pci_read_config_word(PIIX4_dev, SMBBA, &piix4_smba); > piix4_smba &= 0xfff0; > - if(piix4_smba == 0) { > + if (piix4_smba == 0) { > dev_err(&PIIX4_dev->dev, "SMBus base address " > "uninitialized - upgrade BIOS or use " > "force_addr=0xaddr\n"); did you left this message in three lines on purpose? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |