Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932133AbcJNL4L (ORCPT ); Fri, 14 Oct 2016 07:56:11 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:56057 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754559AbcJNLz6 (ORCPT ); Fri, 14 Oct 2016 07:55:58 -0400 Subject: Re: [PATCH v2] i2c: i2c-piix4: several coding style fixes To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Carlos Palminha References: <20161013223901.16460-1-palminha@synopsys.com> <20161014070825.qlawh2ttlwj24jge@pengutronix.de> CC: , From: Carlos Palminha Message-ID: <3c9ba6ec-c137-fa3c-7b5b-7ea7ed58e865@synopsys.com> Date: Fri, 14 Oct 2016 12:52:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161014070825.qlawh2ttlwj24jge@pengutronix.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.107.25.87] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 770 Lines: 30 On 14-10-2016 08:08, Uwe Kleine-K?nig wrote: > Hello, > > On Thu, Oct 13, 2016 at 11:39:01PM +0100, Carlos Palminha wrote: >> @@ -196,7 +204,7 @@ static int piix4_setup(struct pci_dev *PIIX4_dev, >> } else { >> pci_read_config_word(PIIX4_dev, SMBBA, &piix4_smba); >> piix4_smba &= 0xfff0; >> - if(piix4_smba == 0) { >> + if (piix4_smba == 0) { >> dev_err(&PIIX4_dev->dev, "SMBus base address " >> "uninitialized - upgrade BIOS or use " >> "force_addr=0xaddr\n"); > > did you left this message in three lines on purpose? > Hi Uwe, There were some missing lines. I had some doubts regarding if the "quoted string" could go with more than 80 chars. I see now that checkpatch is ok. I'll resend a v3. > Best regards > Uwe > Regards, C.Palminha