Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932232AbcJNMb1 (ORCPT ); Fri, 14 Oct 2016 08:31:27 -0400 Received: from terminus.zytor.com ([198.137.202.10]:49372 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755872AbcJNMbR (ORCPT ); Fri, 14 Oct 2016 08:31:17 -0400 Date: Fri, 14 Oct 2016 05:30:42 -0700 From: tip-bot for Noam Camus Message-ID: Cc: noamca@mellanox.com, linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de Reply-To: linux-kernel@vger.kernel.org, noamca@mellanox.com, mingo@kernel.org, hpa@zytor.com, tglx@linutronix.de In-Reply-To: <1476364532-12634-1-git-send-email-noamca@mellanox.com> References: <1476364532-12634-1-git-send-email-noamca@mellanox.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:irq/urgent] irqchip/eznps: Acknowledge NPS_IPI before calling the handler Git-Commit-ID: c0ca8df717061ae3d2ea624024033103c64210ae X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 49 Commit-ID: c0ca8df717061ae3d2ea624024033103c64210ae Gitweb: http://git.kernel.org/tip/c0ca8df717061ae3d2ea624024033103c64210ae Author: Noam Camus AuthorDate: Thu, 13 Oct 2016 16:15:32 +0300 Committer: Thomas Gleixner CommitDate: Fri, 14 Oct 2016 14:26:54 +0200 irqchip/eznps: Acknowledge NPS_IPI before calling the handler IPI_IRQ (also TIMER0_IRQ) should be acked before the action->handler is called in handle_percpu_devid_irq. The IPI irq is edge sensitive and we might miss an IPI interrupt if it is triggered again while the handler runs. Fixes: 44df427c894a ("irqchip: add nps Internal and external irqchips") Signed-off-by: Noam Camus Cc: marc.zyngier@arm.com Cc: jason@lakedaemon.net Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/1476364532-12634-1-git-send-email-noamca@mellanox.com Signed-off-by: Thomas Gleixner --- drivers/irqchip/irq-eznps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-eznps.c b/drivers/irqchip/irq-eznps.c index efbf0e4..ebc2b0b 100644 --- a/drivers/irqchip/irq-eznps.c +++ b/drivers/irqchip/irq-eznps.c @@ -85,7 +85,7 @@ static void nps400_irq_eoi_global(struct irq_data *irqd) nps_ack_gic(); } -static void nps400_irq_eoi(struct irq_data *irqd) +static void nps400_irq_ack(struct irq_data *irqd) { unsigned int __maybe_unused irq = irqd_to_hwirq(irqd); @@ -103,7 +103,7 @@ static struct irq_chip nps400_irq_chip_percpu = { .name = "NPS400 IC", .irq_mask = nps400_irq_mask, .irq_unmask = nps400_irq_unmask, - .irq_eoi = nps400_irq_eoi, + .irq_ack = nps400_irq_ack, }; static int nps400_irq_map(struct irq_domain *d, unsigned int virq,