Message-ID: <1476451721.11366.15.camel@xs4all.nl>
Subject: Add "lightnvm: ensure that nvm_dev_ops can be used without
 CONFIG_NVM" to v4.4.y stable tree?
From: Paul Bolle <lkml@xs4all.nl>
To: Jens Axboe <axboe@fb.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org
Date: Fri, 14 Oct 2016 15:28:41 +0200
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 872
Lines: 22

Hi,

I had a build of v4.4.24, with CONFIG_NVM not set, fail like this:
    drivers/block/null_blk.c:569:27: error: storage size of 'null_lnvm_dev_ops' isn't known
     static struct nvm_dev_ops null_lnvm_dev_ops;
                               ^~~~~~~~~~~~~~~~~
    scripts/Makefile.build:264: recipe for target 'drivers/block/null_blk.o' failed
    make[2]: *** [drivers/block/null_blk.o] Error 1
    scripts/Makefile.build:403: recipe for target 'drivers/block' failed
    make[1]: *** [drivers/block] Error 2
    Makefile:959: recipe for target 'drivers' failed
    make: *** [drivers] Error 2

Jens' commit a7fd9a4f3e81 ("lightnvm: ensure that nvm_dev_ops can be
used without CONFIG_NVM") fixed that for me (it did require a small
context change to get it applied to v4.4.24). Does it make sense to add
that commit to the v4.4.y stable tree?

Thanks,


Paul Bolle