Date: Fri, 14 Oct 2016 15:47:48 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Paul Bolle <lkml@xs4all.nl>
Cc: Jens Axboe <axboe@fb.com>, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: Add "lightnvm: ensure that nvm_dev_ops can be used without
 CONFIG_NVM" to v4.4.y stable tree?
Message-ID: <20161014134748.GA28581@kroah.com>
References: <1476451721.11366.15.camel@xs4all.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1476451721.11366.15.camel@xs4all.nl>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1086
Lines: 25

On Fri, Oct 14, 2016 at 03:28:41PM +0200, Paul Bolle wrote:
> Hi,
> 
> I had a build of v4.4.24, with CONFIG_NVM not set, fail like this:
> ? ??drivers/block/null_blk.c:569:27: error: storage size of 'null_lnvm_dev_ops' isn't known
>      static struct nvm_dev_ops null_lnvm_dev_ops;
>                                ^~~~~~~~~~~~~~~~~
>     scripts/Makefile.build:264: recipe for target 'drivers/block/null_blk.o' failed
>     make[2]: *** [drivers/block/null_blk.o] Error 1
>     scripts/Makefile.build:403: recipe for target 'drivers/block' failed
>     make[1]: *** [drivers/block] Error 2
>     Makefile:959: recipe for target 'drivers' failed
>     make: *** [drivers] Error 2
> 
> Jens' commit a7fd9a4f3e81 ("lightnvm: ensure that nvm_dev_ops can be
> used without CONFIG_NVM") fixed that for me (it did require a small
> context change to get it applied to v4.4.24). Does it make sense to add
> that commit to the v4.4.y stable tree?

Makes sense to me, can you forward on a patch that applies cleanly and
I'll queue it up for the next round (after this one.)

thanks,

greg k-h