Date: Fri, 14 Oct 2016 12:49:59 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alexis Berlemont <alexis.berlemont@gmail.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com
Subject: Re: [PATCH] perf: dynamically change verbosity level in perf top
Message-ID: <20161014154959.GG12815@kernel.org>
References: <20161012214823.14324-1-alexis.berlemont@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161012214823.14324-1-alexis.berlemont@gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1069
Lines: 37

Em Wed, Oct 12, 2016 at 11:48:22PM +0200, Alexis Berlemont escreveu:
> Hi,
> 
> Here is a small patch which tries to fulfill a point in the perf todo
> list:
> 
> * Make pressing 'V' multiple times to go on cycling thru various
>   verbosity levels in 'perf top', so that info that is present in
>   'perf top -v' can be obtained without having to restart the tool
>   (acme).
> 
> After a small grep in the code, the max verbosity level seems 3; so,
> we cycle at 4; I did not dare define a MAX_VERBOSE_LEVEL constant.
 
Works like a charm, thanks for doing this, feel free to go over other
entries in that list :-)

I made changes only in the cset log message, adding the text you wrote
above and adding a:

Suggested-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Thanks!

- Arnaldo

> Alexis.
> 
> Alexis Berlemont (1):
>   perf: dynamically change verbosity level in perf top
> 
>  tools/perf/ui/browsers/hists.c |  5 ++++-
>  tools/perf/util/map.c          | 17 ++++++++++++-----
>  2 files changed, 16 insertions(+), 6 deletions(-)
> 
> -- 
> 2.10.0