Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755556AbcJNTN3 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 14 Oct 2016 15:13:29 -0400
Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:33705 "EHLO
        SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753784AbcJNTNW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Oct 2016 15:13:22 -0400
X-IronPort-AV: E=Sophos;i="5.31,346,1473120000"; 
   d="scan'208";a="33075914"
Subject: Re: [Xen-devel] [PATCH 4/8] xen/pvh: Bootstrap PVH guest
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        <david.vrabel@citrix.com>, <JGross@suse.com>
References: <1476468318-24422-1-git-send-email-boris.ostrovsky@oracle.com>
 <1476468318-24422-5-git-send-email-boris.ostrovsky@oracle.com>
 <81d91a68-baf6-06b1-3352-73bea05a2738@citrix.com>
 <87039f16-ab7d-d091-a28a-2e2a1a5b81fe@oracle.com>
CC: Matt Fleming <matt@codeblueprint.co.uk>,
        <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>,
        <roger.pau@citrix.com>
From: Andrew Cooper <andrew.cooper3@citrix.com>
Message-ID: <f8199e1a-0bef-61ff-8cad-e1713c9f10a3@citrix.com>
Date: Fri, 14 Oct 2016 20:12:03 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.4.0
MIME-Version: 1.0
In-Reply-To: <87039f16-ab7d-d091-a28a-2e2a1a5b81fe@oracle.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To
 AMSPEX02CL02.citrite.net (10.69.22.126)
X-DLP: AMS1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 864
Lines: 28

On 14/10/16 19:55, Boris Ostrovsky wrote:
> On 10/14/2016 02:38 PM, Andrew Cooper wrote:
>>> +	jmp *%rax
>>> +
>>> +#else /* CONFIG_X86_64 */
>>> +
>>> +	call setup_pgtable_32
>>> +
>>> +	mov $_pa(initial_page_table), %eax
>>> +	movl %eax, %cr3
>>> +
>>> +	movl %cr0, %eax
>>> +	orl $(X86_CR0_PG | X86_CR0_PE), %eax
>>> +	movl %eax, %cr0
>>> +
>>> +	ljmp $__BOOT_CS,$1f
>>> +1:
>>> +	call xen_prepare_pvh
>> Why does xen_prepare_pvh need paging?  I can't spot anything which
>> should need it, and it feels conceptually wrong.
> xen_prepare_pvh() deals with virtual addresses. How can we run without paging?

Ah yes - with a high-half kernel, that way around doesn't work.  Sorry
for the noise - I have been spending too long working with virtual
addresses down round 0, where that specifically can be solved by setting
%ds with a suitable non-zero base.

~Andrew