Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756605AbcJNTTm (ORCPT ); Fri, 14 Oct 2016 15:19:42 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:44954 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755071AbcJNTTk (ORCPT ); Fri, 14 Oct 2016 15:19:40 -0400 Date: Fri, 14 Oct 2016 15:19:23 -0400 From: Konrad Rzeszutek Wilk To: Boris Ostrovsky Cc: david.vrabel@citrix.com, JGross@suse.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, roger.pau@citrix.com Subject: Re: [Xen-devel] [PATCH 6/8] xen/pvh: Initialize grant table for PVH guests Message-ID: <20161014191923.GD16777@localhost.localdomain> References: <1476468318-24422-1-git-send-email-boris.ostrovsky@oracle.com> <1476468318-24422-7-git-send-email-boris.ostrovsky@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476468318-24422-7-git-send-email-boris.ostrovsky@oracle.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1356 Lines: 48 On Fri, Oct 14, 2016 at 02:05:16PM -0400, Boris Ostrovsky wrote: Perhaps add in here: PVH is like PV in that there are no PCI devices - which HVM code would piggyback on to find the Xen PCI platform device and use its MMIO space to stash the grants in. For PVH we balloon out memory and stash the grants in there. (Which begs the next question - where and when do we balloon out the normal memory back in?) > Signed-off-by: Boris Ostrovsky > --- > drivers/xen/grant-table.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c > index bb36b1e..d6786b8 100644 > --- a/drivers/xen/grant-table.c > +++ b/drivers/xen/grant-table.c > @@ -1146,13 +1146,13 @@ int gnttab_init(void) > > static int __gnttab_init(void) > { > + if (!xen_domain()) > + return -ENODEV; > + > /* Delay grant-table initialization in the PV on HVM case */ > - if (xen_hvm_domain()) > + if (xen_hvm_domain() && !xen_pvh_domain()) > return 0; > > - if (!xen_pv_domain()) > - return -ENODEV; > - > return gnttab_init(); > } > /* Starts after core_initcall so that xen_pvh_gnttab_setup can be called > -- > 1.8.3.1 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel